From 0202dc51af7c620dd71dd5cd13711b861c5601a0 Mon Sep 17 00:00:00 2001
From: Cal <3027929699@qq.com>
Date: Tue, 9 Apr 2024 14:19:54 +0800
Subject: [PATCH] fix the bug of bfs

---
 Assets/Scripts/BFS/BFS.cs | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/Assets/Scripts/BFS/BFS.cs b/Assets/Scripts/BFS/BFS.cs
index fcc6910..03ff9e4 100644
--- a/Assets/Scripts/BFS/BFS.cs
+++ b/Assets/Scripts/BFS/BFS.cs
@@ -172,6 +172,7 @@ public class BFS<T>
     private List<int> _closeList = new List<int>();
     private Queue<int> _openList = new Queue<int>();
     private Dictionary<Node<T>, Node<T>> _nodeMap = new Dictionary<Node<T>, Node<T>>();
+    private List<int> ids = new List<int>();
 
     public BFS(Graph<T> graph)
     {
@@ -186,6 +187,10 @@ public class BFS<T>
 
     public Path<T> FindPath(Node<T> begin, Node<T> end)
     {
+        if (begin == null)
+            throw new NullReferenceException("begin");
+        if (end == null)
+            throw new NullReferenceException("end");
         _openList.Clear();
         _closeList.Clear();
         _nodeMap.Clear();
@@ -220,12 +225,6 @@ public class BFS<T>
         {
             if (this._nodeMap.TryGetValue(node, out node))
             {
-                if (node != null)
-                {
-                    Debug.Log($"{node.index} is null");
-                    isTrue = false;
-                    break;
-                }
 
                 if (!this.ids.Contains(node.index))
                 {
@@ -234,11 +233,10 @@ public class BFS<T>
                     path.AddNode(new PathNode<T>(node.index, node.data));
                 }
             }
-
-            if (node == begin)
+            
+            if (node==null || node == begin)
             {
                 Debug.Log("结束了");
-                isTrue = false;
                 break;
             }
         }
@@ -247,9 +245,6 @@ public class BFS<T>
         return path;
     }
 
-// add
-    private List<int> ids = new List<int>();
-
     private void Search(Node<T> node)
     {
         var readOnlyList = this._graph.GetNeighbours(node);
-- 
2.25.1